Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host Split Update host build pipeline to publish a new FunctionsInproc site extension #9817

Merged
merged 32 commits into from
Feb 1, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Jan 18, 2024

Issue describing the changes in this PR

resolves #9722

On a high level, the pipeline pushes the dev branch to release/4.x and release/inproc6/4.x. The first branch will generate an artifact called Functions.4.1030.zip and the second branch will generate an artifact called FunctionsInProc.4.630.zip.

We are calling in-proc 4.6xx and OOP 4.10xx to specify the host .NET version without having to make another query. So 4.6xx means we're using .NET 6. We chose to add 10 to the minor prefix of the version since we want the version for isolated to be larger than the version for in-proc.

The following site extension is built when testing with aishwarya/release/inproc6/4.99:
image

And the following site extension is built when testing with aishwarya/release/4.99:
image

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh aishwaryabh marked this pull request as ready for review January 22, 2024 22:25
@aishwaryabh aishwaryabh requested a review from a team as a code owner January 22, 2024 22:25
build/common.props Show resolved Hide resolved
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why we chose in-proc to have 4.6xx versions and out of proc 4.10xx?

@aishwaryabh
Copy link
Contributor Author

Can you elaborate on why we chose in-proc to have 4.6xx versions and out of proc 4.10xx?

I added an additional description to the PR:

We are calling in-proc 4.6xx and OOP 4.10xx to specify the host .NET version without having to make another query. So 4.6xx means we're using .NET 6. We chose to add 10 to the minor prefix of the version since we want the version for isolated to be larger than the version for in-proc.

@jviau
Copy link
Contributor

jviau commented Jan 25, 2024

Okay. Now I am wondering why 10 and not 8 😆 , as it is .net8

@brettsam
Copy link
Member

brettsam commented Jan 30, 2024

@jviau -- there will be a 4.8xx coming soon -- specifically for .NET 8 in-proc support (we'll have 3 flavors of v4 for some time...).

We chose 10xx just to get higher than that so we would avoid any future conflict. We don't expect many .NET 8 in-proc releases -- and certainly not 200 of them to catch up, but 10xx just seemed nice and round.

And while the new out-of-proc is going to be .NET 8... it'll also move to .NET 9, 10, 11, etc, so the prefix wasn't super-critical for matching that version. It's going to be long-lived so we just wanted that prefix to be high enough to be "out of the way".

build/build-extensions.ps1 Outdated Show resolved Hide resolved
build/build-extensions.ps1 Outdated Show resolved Hide resolved
@aishwaryabh aishwaryabh merged commit a77bf00 into dev Feb 1, 2024
9 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/host-split branch February 1, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host Split: Update host build pipeline to publish a new FunctionsInproc site extension
4 participants