Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pack] Use dotnet common artifacts output #9858

Merged
merged 22 commits into from
Apr 26, 2024
Merged

[pack] Use dotnet common artifacts output #9858

merged 22 commits into from
Apr 26, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Feb 2, 2024

Issue describing the changes in this PR

Part of #9824

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR onboards this repo to .NET8 artifacts output: https://learn.microsoft.com/en-us/dotnet/core/sdk/artifacts-output. Using this system, all build artifacts from all projects will go into a common directory in the repo root: out/. The layout is:

  • out/bin/{ProjectName}/{Pivot}: build output
  • out/obj/{ProjectName}/{Pivot}: intermediate output
  • out/pub/{ProjectName}/{Pivot}: publish output
  • out/pkg/{ProjectName}/{Pivot}: pack output

{Pivot} being {configuration}(_{targetFramework})?(_{runtime})?

CI scripts have been updated to handle the new output locations.

Test updates are still in progress

@jviau jviau requested a review from a team as a code owner February 2, 2024 00:41
@liliankasem liliankasem self-requested a review March 29, 2024 20:29
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments, but the SDK version requires a change.

azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
build/build-extensions.ps1 Show resolved Hide resolved
build/initialize-pipeline.ps1 Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
@jviau jviau requested a review from fabiocav April 26, 2024 18:11
@jviau jviau merged commit af6336d into dev Apr 26, 2024
10 checks passed
@jviau jviau deleted the jviau/eng/artifacts2 branch April 26, 2024 19:52
jviau added a commit that referenced this pull request Apr 29, 2024
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
# Conflicts:
#	build/build-extensions.ps1
#	test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs
#	test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav pushed a commit that referenced this pull request May 1, 2024
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
# Conflicts:
#	build/build-extensions.ps1
#	test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs
#	test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav pushed a commit that referenced this pull request May 1, 2024
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
# Conflicts:
#	build/build-extensions.ps1
#	test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs
#	test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav pushed a commit that referenced this pull request May 7, 2024
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
fabiocav pushed a commit that referenced this pull request May 8, 2024
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants