-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pack] Use dotnet common artifacts output #9858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
force-pushed
the
jviau/eng/artifacts2
branch
from
February 2, 2024 00:44
ef7dfb4
to
138f0d3
Compare
liliankasem
approved these changes
Feb 14, 2024
liliankasem
approved these changes
Apr 4, 2024
test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs
Outdated
Show resolved
Hide resolved
...tensionsMetadataGenerator/src/ExtensionsMetadataGenerator/ExtensionsMetadataGenerator.csproj
Show resolved
Hide resolved
fabiocav
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, but the SDK version requires a change.
fabiocav
approved these changes
Apr 26, 2024
This was referenced Apr 26, 2024
Merged
jviau
added a commit
that referenced
this pull request
Apr 29, 2024
* Use dotnet common artifacts output * Fix test paths * Fix more tests * Compress-Archive fix attempt * Fix more tests * Remove verbose log from build script * Update build-extensions.ps1 * Remove release_* from esrp signing * Force build * Allow for packing via --pack * Use powershell core --pack * Force build --pack * Fix pwsh --pack * Upgrade back to .NET8 * Fix copy-paste error * Fix Verify_DepsJsonChanges * Undo SDK upgrade # Conflicts: # build/build-extensions.ps1 # test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs # test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav
pushed a commit
that referenced
this pull request
May 1, 2024
* Use dotnet common artifacts output * Fix test paths * Fix more tests * Compress-Archive fix attempt * Fix more tests * Remove verbose log from build script * Update build-extensions.ps1 * Remove release_* from esrp signing * Force build * Allow for packing via --pack * Use powershell core --pack * Force build --pack * Fix pwsh --pack * Upgrade back to .NET8 * Fix copy-paste error * Fix Verify_DepsJsonChanges * Undo SDK upgrade # Conflicts: # build/build-extensions.ps1 # test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs # test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav
pushed a commit
that referenced
this pull request
May 1, 2024
* Use dotnet common artifacts output * Fix test paths * Fix more tests * Compress-Archive fix attempt * Fix more tests * Remove verbose log from build script * Update build-extensions.ps1 * Remove release_* from esrp signing * Force build * Allow for packing via --pack * Use powershell core --pack * Force build --pack * Fix pwsh --pack * Upgrade back to .NET8 * Fix copy-paste error * Fix Verify_DepsJsonChanges * Undo SDK upgrade # Conflicts: # build/build-extensions.ps1 # test/WebJobs.Script.Tests.Integration/Controllers/ControllerScenarioTestFixture.cs # test/WebJobs.Script.Tests/DependencyTests.cs
fabiocav
pushed a commit
that referenced
this pull request
May 7, 2024
* Use dotnet common artifacts output * Fix test paths * Fix more tests * Compress-Archive fix attempt * Fix more tests * Remove verbose log from build script * Update build-extensions.ps1 * Remove release_* from esrp signing * Force build * Allow for packing via --pack * Use powershell core --pack * Force build --pack * Fix pwsh --pack * Upgrade back to .NET8 * Fix copy-paste error * Fix Verify_DepsJsonChanges * Undo SDK upgrade
fabiocav
pushed a commit
that referenced
this pull request
May 8, 2024
* Use dotnet common artifacts output * Fix test paths * Fix more tests * Compress-Archive fix attempt * Fix more tests * Remove verbose log from build script * Update build-extensions.ps1 * Remove release_* from esrp signing * Force build * Allow for packing via --pack * Use powershell core --pack * Force build --pack * Fix pwsh --pack * Upgrade back to .NET8 * Fix copy-paste error * Fix Verify_DepsJsonChanges * Undo SDK upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Part of #9824
Pull request checklist
release_notes.md
Additional information
This PR onboards this repo to .NET8 artifacts output: https://learn.microsoft.com/en-us/dotnet/core/sdk/artifacts-output. Using this system, all build artifacts from all projects will go into a common directory in the repo root:
out/
. The layout is:out/bin/{ProjectName}/{Pivot}
: build outputout/obj/{ProjectName}/{Pivot}
: intermediate outputout/pub/{ProjectName}/{Pivot}
: publish outputout/pkg/{ProjectName}/{Pivot}
: pack output{Pivot}
being{configuration}(_{targetFramework})?(_{runtime})?
CI scripts have been updated to handle the new output locations.
Test updates are still in progress