Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include route params in RpcHttp instance when http proxying is enabled. #9997

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Include route params in RpcHttp instance when http proxying is enabled. #9997

merged 2 commits into from
Apr 25, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Apr 11, 2024 •
edited
Loading

Fixes #9840
Adding support for workers to request route params data populated in the RpcHttp instance when Http proxying is enabled.
Worker needs to include "RequiresRouteParameters" capability in the capability list they send to host during init/env reload request for this to happen.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • [] Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR - backport PR follows shortly.
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner April 11, 2024 20:38
@kshyju kshyju mentioned this pull request Apr 11, 2024
Merged
@kshyju kshyju requested a review from ejizba April 11, 2024 21:22
@kshyju kshyju force-pushed the shkr/9840_route_params_for_http_proxy branch from 2f1cd58 to 4e0d775 Compare April 15, 2024 22:38
ejizba
ejizba approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Node.js app and worked just fine!

@YunchuWang
Copy link
Contributor

Validated the change works in python http v2 app, can grab the route params from rpchttp and set into fastapi req
image
image
image

@kshyju kshyju requested a review from satvu April 22, 2024 23:40
fabiocav
fabiocav reviewed Apr 24, 2024
View reviewed changes
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/Workers/Rpc/RpcWorkerConstants.cs Outdated Show resolved Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script.Grpc/MessageExtensions/GrpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
@kshyju kshyju requested a review from fabiocav April 25, 2024 15:25
@kshyju kshyju merged commit 7ea046b into dev Apr 25, 2024
9 checks passed
@kshyju kshyju deleted the shkr/9840_route_params_for_http_proxy branch April 25, 2024 16:52
kshyju added a commit that referenced this pull request Apr 25, 2024
@kshyju
Include route params in RpcHttp instance when http proxying is enable…
8c24e87 
…d. (#9997)

* Include route params in RpcHttp instance when http proxying is enabled.

* Fixes to address PR comments.
@kshyju kshyju mentioned this pull request Apr 25, 2024
Merged
9 tasks
kshyju added a commit that referenced this pull request Apr 27, 2024
@kshyju
Include route params in RpcHttp instance when http proxying is enable…
2462997 
…d. (#9997) (#10072)

* Include route params in RpcHttp instance when http proxying is enabled.

* Fixes to address PR comments.
fabiocav pushed a commit that referenced this pull request Apr 29, 2024
@kshyju @fabiocav
Include route params in RpcHttp instance when http proxying is enable…
94da8db 
…d. (#9997) (#10072)

* Include route params in RpcHttp instance when http proxying is enabled.

* Fixes to address PR comments.
YunchuWang added a commit to Azure/azure-functions-python-worker that referenced this pull request May 6, 2024
@YunchuWang
Http V2 route params update
064a1bd 
Worker Changes to get route parameters of http invocation request from invocation request "route_params" attributes after host made update in Azure/azure-functions-host#9997.

TODO: Update lc test after lc image released with host version containing the change.
@YunchuWang YunchuWang mentioned this pull request May 6, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav approved these changes

@ejizba ejizba ejizba approved these changes

@YunchuWang YunchuWang YunchuWang approved these changes

@satvu satvu satvu approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@vrdmr vrdmr Awaiting requested review from vrdmr

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna

@Francisco-Gamino Francisco-Gamino Awaiting requested review from Francisco-Gamino

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide route params to worker when using http proxy
5 participants
@kshyju @YunchuWang @fabiocav @ejizba @satvu