Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must have CI/CD process #25

Closed
ryancrawcour opened this issue Mar 20, 2019 · 9 comments
Closed

Must have CI/CD process #25

ryancrawcour opened this issue Mar 20, 2019 · 9 comments
Milestone

Comments

@ryancrawcour
Copy link
Contributor

Must have AzDO CI/CD pipelines to auto build, test, and publish component

@fbeltrao
Copy link
Contributor

How far should the CI at this stage go? Should we create nuget packages? If yes, we need guidelines from team in how to version, build and deploy them.

@ryancrawcour
Copy link
Contributor Author

Is there value in publishing this component on NuGet? If they pull it down, can they just start using it in their own Functions provided they're not using Consumption but App Svc?

@jeffhollan & @anirudhgarg should we publish this on NuGet? or do we just leave it in the repo and people that want it can pull it down, build it, and then deploy and configure on their environment.

@jeffhollan
Copy link

Yes ideally this should go on NuGet as Microsoft.Azure.WebJobs.Extensions.Kafka With a pre-release flag. @paulbatum and @fabiocav are the right people to set you up with the right process

@jeffhollan
Copy link

I would hold off on doing the NuGet stuff yet. It will largely depend on when and how it is managed long term (e.g. when bug fixes need to go in, how they get pushed out). For now it may be ad-hoc publishing, automated to our NuGet through our build pipeline, etc. Worth having a conversation first about that before we go too far down this path

@ryancrawcour
Copy link
Contributor Author

happy to have that convo. for now we can have ad-hoc publish to NuGet

@TsuyoshiUshio TsuyoshiUshio added the blocked Waiting for someone else to resolve label Apr 3, 2019
@TsuyoshiUshio
Copy link
Contributor

According to the conversation with the product team. We resume the conversation next week.

@ryancrawcour
Copy link
Contributor Author

Agreed. Manual publish to NuGet, for now, until the final resting home for this is found. For now, let's just ensure that our CI/CD does the following -

CI - registers all OSS components correctly & runs all unit tests (yes, we need better unit tests, but we'll work on that as a separate issue)

CD - runs full end to end functional tests

@TsuyoshiUshio
Copy link
Contributor

Hi @ryancrawcour When I have a look, the CI pipeline already include the e2e testing and it works.
I do nothing. Maybe already @fbeltrao done a very good job! :) Anything else am I missing?

Anything else do we need? Maybe next step is the publishing manually and create a pipeline on the product team's Azure DevOps.

image

@ryancrawcour
Copy link
Contributor Author

Ok. Closing it out and we will revisit the CD requirements when we integrate in to the PG processes.

@ryancrawcour ryancrawcour removed the blocked Waiting for someone else to resolve label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants