Update Java samples, documentation, fix Windows issue. #138
Conversation
| Remove following line. This line is windows only. | ||
|
|
||
| ```java | ||
| sslCaLocation = "confluent_cloud_cacert.pem", // Remove this attribute for Linux/Mac users. |
There was a problem hiding this comment.
Why is only for linux/mac, not windows?
There was a problem hiding this comment.
Linux and mac works without this. Windows requires. Probably, the default cacert already includes it. (I didn't need it when I use Mac and deploy to Linux Premium)
There was a problem hiding this comment.
The original documentation mention it. https://github.com/confluentinc/examples/tree/5.4.0-post/clients/cloud/csharp#produce-records
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <azure.functions.maven.plugin.version>1.5.0</azure.functions.maven.plugin.version> | ||
| <azure.functions.java.library.version>1.3.0</azure.functions.java.library.version> | ||
| <functionAppName>kafka-function-20190419163130420</functionAppName> |
There was a problem hiding this comment.
Is there a way to mention that the app name need to be updated as it should be unique?
There was a problem hiding this comment.
Good point! I wrote it on the documentation, however, I'd like to find a way to write something around here.
| authenticationMode = BrokerAuthenticationMode.PLAIN, | ||
| protocol = BrokerProtocol.SASLSSL, | ||
| sslCaLocation = "confluent_cloud_cacert.pem", // Remove this attribute for Linux/Mac users. |
There was a problem hiding this comment.
Can we please check removing it with not throw any warnings?
There was a problem hiding this comment.
For the windows, It could be a problem. Windows has the entry on Registry. However, .NetCore can't see the registry. That is why we need to add pem only on windows.
|
@TsuyoshiUshio Thank you so much sir for your answers! |
I update the java implementation on these points.
Update
Test