Shrohilla/kafka header bindings

[shrohilla]

1. Added the support for the kafka headers for output bindings
2. Reconverting the object from string check if the required params exists than create the KafkaEventData
3. It doesn't require the unit test case as the class is internal class

[shrohilla]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[TsuyoshiUshio]

Some naming convention issue is there. However generally looks good.
One thing I'd like to recommend is, write unit test. You can use internal scope for enabling unit testing with internalVisuleTo https://codesnippets.fesslersoft.de/use-the-assembly-internalsvisibleto-attribute/

Automated testing seems to fail.

[shrohilla]

Some naming convention issue is there. However generally looks good. One thing I'd like to recommend is, write unit test. You can use internal scope for enabling unit testing with internalVisuleTo https://codesnippets.fesslersoft.de/use-the-assembly-internalsvisibleto-attribute/

Automated testing seems to fail.

Hi @TsuyoshiUshio I had addressed all the comments shared and created the unit test cases also, please review the code

[TsuyoshiUshio]

The unit tests should include the testing for headers since you added headers feature. You can share the spec and prove it works with variation with writing unit tests.

[shrohilla]

The unit tests should include the testing for headers since you added headers feature. You can share the spec and prove it works with variation with writing unit tests.

@TsuyoshiUshio -- Already added that in the test -- AddAsync_Item_Is_Of_KafkaEventData_Json_String_Types
It contains headers details also

[TsuyoshiUshio]

Hi @shrohilla
The test doesn't include assertion or validation using Moq. Am I missing something? Usually, test cases will be constructed by three sections.

1. Setup
2. Run the target
3. Assertion/Validation
   However, on your test case I can't find it. For example. https://github.com/Azure/azure-functions-kafka-extension/blob/dev/test/Microsoft.Azure.WebJobs.Extensions.Kafka.UnitTests/KafkaProducerFactoryTest.cs For the validation of the Moq will be https://makolyte.com/moq-verifying-parameters-passed-to-a-mocked-method/#:~:text=When%20you%20need%20to%20verify%20that%20the%20code,expected%20with%20the%20specified%20parameters.%20Here%E2%80%99s%20an%20example.

[shrohilla]

Hi @shrohilla The test doesn't include assertion or validation using Moq. Am I missing something? Usually, test cases will be constructed by three sections.

1. Setup
2. Run the target
3. Assertion/Validation
   However, on your test case I can't find it. For example. https://github.com/Azure/azure-functions-kafka-extension/blob/dev/test/Microsoft.Azure.WebJobs.Extensions.Kafka.UnitTests/KafkaProducerFactoryTest.cs For the validation of the Moq will be https://makolyte.com/moq-verifying-parameters-passed-to-a-mocked-method/#:~:text=When%20you%20need%20to%20verify%20that%20the%20code,expected%20with%20the%20specified%20parameters.%20Here%E2%80%99s%20an%20example.

@TsuyoshiUshio Added the few possible validations, will add this scenario in the E2E tests for language workers as a separate task.