Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing the Little Endian issue #315

Merged
merged 2 commits into from Apr 12, 2022
Merged

fixing the Little Endian issue #315

merged 2 commits into from Apr 12, 2022

Conversation

shrohilla
Copy link
Contributor

changed from Unicode to UTF8
No Unit test required already covered.

@shrohilla
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jainharsh98
jainharsh98 reviewed Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@jainharsh98 jainharsh98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mention where was this causing an issue? From what I understand using Unicode will encode it into 2 bytes in little endian format. Why are we changing it to 1 byte?

@shrohilla
Copy link
Contributor Author

Can you please mention where was this causing an issue? From what I understand using Unicode will encode it into 2 bytes in little endian format. Why are we changing it to 1 byte?

By-default the headers are encoded with UTF-8 and the Unicode will encode it in Little Endian mode which will confuse the customer

jainharsh98
jainharsh98 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@jainharsh98 jainharsh98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrohilla shrohilla merged commit 2793df9 into dev Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainharsh98 jainharsh98 jainharsh98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shrohilla @jainharsh98