New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Trigger documentation and Modifying Output documentation #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainharsh98
requested review from
shrohilla and
krishna-kariya
and removed request for
shrohilla
April 27, 2022 08:01
shrohilla
suggested changes
Apr 27, 2022
ghost
added
the
Needs: author feedback
label
Apr 27, 2022
ghost
removed
the
Needs: author feedback
label
Apr 27, 2022
shrohilla
suggested changes
Apr 27, 2022
ghost
added
the
Needs: author feedback
label
Apr 27, 2022
ghost
removed
the
Needs: author feedback
label
Apr 28, 2022
jainharsh98
changed the title
Adding Trigger documentation
Adding Trigger documentation and Modifying Output documentation
May 2, 2022
shrohilla
reviewed
May 2, 2022
shrohilla
reviewed
May 2, 2022
shrohilla
reviewed
May 2, 2022
* Added Examples Section in Trigger and Output * Adding description for python example * Added typescript example and addressed other comments * Adding link to Java client library * Added examples for batch event type in trigger * Added examples for batch event type in output
…ctions-kafka-extension into jainh/triggerDoc
* Added headers samples for trigger and output * Fixing the examples
shrohilla
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.