Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sample cases for byte[] and byte[][] triggers #52

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Adding sample cases for byte[] and byte[][] triggers #52

merged 5 commits into from
Apr 4, 2019

Conversation

brandonh-msft
Copy link
Member

Turns out task 3 of #44 doesn't require any additional work; we got it for free. Added samples demonstrating

fbeltrao
fbeltrao reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@fbeltrao fbeltrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I recommend adding E2E tests to ensure that byte[] is working and getting one item at a time. The same way that byte[][] is processing message batches.

src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/KafkaExtensionConfigProvider.cs Show resolved Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Config/KafkaExtensionConfigProvider.cs Show resolved Hide resolved
@brandonh-msft
Copy link
Member Author

brandonh-msft commented Apr 3, 2019 •
edited
Loading

I recommend adding E2E tests to ensure that byte[] is working and getting one item at a time. The same way that byte[][] is processing message batches.

I agree, but it wasn't clear to me how to write tests to exercise this... had quite a time when I tried.

ryancrawcour
ryancrawcour previously requested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@ryancrawcour ryancrawcour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on tests as discussed in conversation. Or open an issue to track tests separately if you want to push this through.

@brandonh-msft
Copy link
Member Author

@ryancrawcour worked thru the test case adds w/ @fbeltrao & we're all good now. Added to e2es and passing. ⏲

@brandonh-msft
Copy link
Member Author

@fbeltrao plz review & merge, thanks!

@brandonh-msft brandonh-msft merged commit b0ec76a into Azure:master Apr 4, 2019
@brandonh-msft brandonh-msft deleted the brandonh/fix-44-no3-redux branch April 4, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeltrao fbeltrao fbeltrao approved these changes

@ryancrawcour ryancrawcour Awaiting requested review from ryancrawcour

Assignees

@brandonh-msft brandonh-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandonh-msft @fbeltrao @ryancrawcour