The first implementation of Java #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeltrao
reviewed
Apr 24, 2019
...g-library/java/src/main/java/com/microsoft/azure/functions/kafka/annotation/KafkaOutput.java
Outdated
Show resolved
Hide resolved
...-library/java/src/main/java/com/microsoft/azure/functions/kafka/annotation/KafkaTrigger.java
Outdated
Show resolved
Hide resolved
pragnagopa
reviewed
Apr 24, 2019
binding-library/java/src/main/java/com/microsoft/azure/functions/kafka/KafkaEventData.java
Outdated
Show resolved
Hide resolved
TsuyoshiUshio
changed the title
pragnagopa
reviewed
Apr 26, 2019
...g-library/java/src/main/java/com/microsoft/azure/functions/kafka/annotation/KafkaOutput.java
Outdated
Show resolved
Hide resolved
|
Is this good to be merged? Looks like all issues have been resolved. |
|
@ryancrawcour Once I can create a sample of the output bindings, It is ready to merge. |
|
This PR works after #82 is merged. |
ryancrawcour
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
The Java implementation start working. Since this PR doesn't destroy the source exists, I create a PR for share/review and indicate the directory structure with other language extensions. I'll keep on update java feature.
Currently, it works on the Trigger. I have no time to work on this week, however, I restart these tasks on next week.