Updating headers to be string type, conversion handled on worker #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
May 31, 2018
src/Converters.ts
Outdated
| for (let key in inputHeaders) { | ||
| rpcHttpHeaders[key] = toTypedData(inputHeaders[key]); | ||
| rpcHttpHeaders[key] = inputHeaders[key].toString(); |
There was a problem hiding this comment.
Check for null or empty values inputHeaders[key]?
pragnagopa
reviewed
May 31, 2018
| for (let key in inputHeaders) { | ||
| rpcHttpHeaders[key] = toTypedData(inputHeaders[key]); | ||
| if (inputHeaders[key] != null) { | ||
| rpcHttpHeaders[key] = inputHeaders[key].toString(); |
There was a problem hiding this comment.
Add test setting the response headers of different types "stringHeader" , 123
pragnagopa
reviewed
May 31, 2018
| for (let key in inputHeaders) { | ||
| rpcHttpHeaders[key] = toTypedData(inputHeaders[key]); | ||
| if (inputHeaders[key] != null) { |
There was a problem hiding this comment.
if(inputHeaders[key]) should take care of undefined , null
There was a problem hiding this comment.
it evaluates to false with a value of 0 though :(
There was a problem hiding this comment.
Ahh. Thanks for checking. Add a test for 0 too.
pragnagopa
approved these changes
May 31, 2018
mhoeger
added a commit
that referenced
this pull request
Jun 5, 2018
* Updating headers to be string type, conversion handled on worker * Null check (ty pragna!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78