Feature/#156 list of recursive models #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Solbjør <220551+tsolbjor@users.noreply.github.com>
Signed-off-by: Thomas Solbjør <220551+tsolbjor@users.noreply.github.com>
|
|
justinyoo
requested changes
Sep 14, 2021
There was a problem hiding this comment.
@tsolbjor Thanks for your PR! I like the idea you implemented!
Could you please add the same logic where you put into ListObjectTypeVisotor to DictionaryObjectTypeVisotor so that both array types and dictionary types work in the same way as each other?
samples/Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.Models/DummyResponseModel.cs
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/ListObjectTypeVisitor.cs
Show resolved
Hide resolved
...WebJobs.Extensions.OpenApi.TestApp/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp.csproj
Outdated
Show resolved
Hide resolved
…Visitor Signed-off-by: Thomas Solbjør <220551+tsolbjor@users.noreply.github.com>
tsolbjor
commented
Sep 14, 2021
...re.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_GenericAndRecursive_HttpTrigger.cs
Show resolved
Hide resolved
justinyoo
approved these changes
Sep 17, 2021
...re.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_GenericAndRecursive_HttpTrigger.cs
Show resolved
Hide resolved
meanstigerkim
pushed a commit
to meanstigerkim/azure-functions-openapi-extension
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of the subAcceptors that have been applied and do not run multiple times for the same type.
#156