Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve TypeLoadException for QueryCollection (#296) #318

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Resolve TypeLoadException for QueryCollection (#296) #318

merged 1 commit into from
Feb 9, 2022

Conversation

AieatAssam
Copy link
Contributor

Related to #296

Changes proposed in this pull request:

  • Add FrameworkReference for Microsoft.AspNetCore.App to Microsoft.Azure.Functions.Worker.Extensions.OpenApi.csproj
  • Replace type reference for QueryCollection from Microsoft.AspNetCore.Http.Internal.QueryCollection (which is not present in AspNetCore-referencing projects and is internal) to framework-provided Microsoft.AspNetCore.Http.QueryCollection

@AieatAssam
Added framework reference to AspNetCore
ff8a90c 
Replaced reference from internal QueryCollection to framework provided one
@ghost
Copy link

ghost commented Nov 18, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@AieatAssam AieatAssam marked this pull request as ready for review November 19, 2021 09:58
@AieatAssam AieatAssam changed the title Resolve TypeLoadException for QueryCollection Resolve TypeLoadException for QueryCollection (#296) Nov 22, 2021
@AieatAssam AieatAssam mentioned this pull request Jan 5, 2022
Closed
@papadi
Copy link

papadi commented Jan 27, 2022

This PR fixes an issue that affects many people (see discussion in references). Any chance somebody can move it forward?

@SilverioMiranda
Copy link

Why haven't they accepted this PR yet?

@SilverioMiranda
Copy link

@justinyoo

@SilverioMiranda SilverioMiranda mentioned this pull request Feb 7, 2022
Closed
justinyoo
justinyoo approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AieatAssam Thanks for the PR and long wait! It looks good to me.

This was linked to issues Feb 9, 2022
TypeLoadException when trying to load QueryCollection in .NET 5/.NET 6 isolated function if Microsoft.AspNetCore.Authentication.JwtBearer is referenced #296
Closed
Swagger UI is not rendering Could not load type 'Microsoft.AspNetCore.Http.Internal.QueryCollection' from assembly 'Microsoft.AspNetCore.Http' #355
Closed
@justinyoo justinyoo merged commit a65cf06 into Azure:main Feb 9, 2022
@justinyoo justinyoo added bug Something isn't working v1.1.0 labels Feb 9, 2022
@olehgerus
Copy link

Thanks @AieatAssam, @justinyoo. When this change will be released?

This was referenced Feb 11, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v1.1.0
Projects
None yet
Milestone
No milestone
5 participants
@AieatAssam @papadi @SilverioMiranda @olehgerus @justinyoo