Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Funktion key from config gets overwritten by function key in url #383

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix: Funktion key from config gets overwritten by function key in url #383

merged 1 commit into from
Mar 22, 2022

Conversation

Derich367
Copy link
Contributor

Fixes #382

justinyoo
justinyoo requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Derich367 Would you please add some test codes to validate your changes?

@Derich367 Derich367 force-pushed the allow-function-specific-funktion-keys branch from 9ab333e to 108ec61 Compare March 22, 2022 09:22
@Derich367
Copy link
Contributor Author

@Derich367 Would you please add some test codes to validate your changes?

@justinyoo I added tests for this behaviour
Also improved behaviour if authKey is required and set in query but not set in function parameters

justinyoo
justinyoo requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test method! I've left a couple of comments for you to take a look.

test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/SwaggerUITests.cs Show resolved Hide resolved
test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/SwaggerUITests.cs Outdated Show resolved Hide resolved
@Derich367 Derich367 force-pushed the allow-function-specific-funktion-keys branch from 108ec61 to 0e3846a Compare March 22, 2022 14:08
justinyoo
justinyoo approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@justinyoo justinyoo added bug Something isn't working v1.3.0 labels Mar 22, 2022
@justinyoo justinyoo added this to the Release 202203 - v1.3.0 milestone Mar 22, 2022
@justinyoo justinyoo merged commit 55eec16 into Azure:main Mar 22, 2022
@xiejiams xiejiams mentioned this pull request May 16, 2022
Open
Derich367 added a commit to Derich367/azure-functions-openapi-extension that referenced this pull request Jan 30, 2023
@Derich367
override function key from query if set in parameters, allow function…
76deea8 
… key to be set from query (Azure#383)

Co-authored-by: Simon Schneider <simon.schneider@gdts.one>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v1.3.0
Projects
None yet
Milestone
Release 202203 - v1.3.0
Development

Successfully merging this pull request may close these issues.

Funktion key from config gets overwritten by function key in url
2 participants
@Derich367 @justinyoo