Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused code related to moq #608

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Delete unused code related to moq #608

merged 2 commits into from
Aug 31, 2023

Conversation

hnnynh
Copy link
Contributor

@hnnynh hnnynh commented Aug 29, 2023 •
edited

Delete useless code in the process of changing Moq to NSubstitute in WebJobs Core.Tests project

test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests.csproj

  • Delete Moq PackageReference from .csproj file

test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Resolvers/HostJsonResolverTests.cs

  • Delete file that contain code using Moq but are annotated

test/Microsoft.Azure.WebJobs.Extensions.OpenApi.AppSettings.Tests/Microsoft.Azure.WebJobs.Extensions.OpenApi.AppSettings.Tests.csproj

  • Delete Moq PackageReference from Appsettings.Tests.csproj file

image
All the tests passed => No Moq codes left in WebJobs Core.Tests Project
Issue #598

@hnnynh hnnynh changed the title Delete useless code Delete useless code in WebJobs Core.Tests project Aug 29, 2023
@hnnynh hnnynh changed the title Delete useless code in WebJobs Core.Tests project Delete useless code related to moq Aug 30, 2023
@justinyoo justinyoo changed the title Delete useless code related to moq Delete unused code related to moq Aug 31, 2023
justinyoo
justinyoo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good catch!

@justinyoo justinyoo added oca-pr For participants from OSS Contribution Academy oca-issue For participants from OSS Contribution Academy labels Aug 31, 2023
@justinyoo justinyoo merged commit ae743ce into Azure:main Aug 31, 2023
8 checks passed
@justinyoo justinyoo added enhancement New feature or request v1.6.0 labels Sep 19, 2023
@justinyoo justinyoo linked an issue Sep 19, 2023 that may be closed by this pull request
Replace Moq with something else #598
Closed
@hnnynh hnnynh deleted the yoonho branch September 29, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request oca-issue For participants from OSS Contribution Academy oca-pr For participants from OSS Contribution Academy v1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Moq with something else
2 participants
@hnnynh @justinyoo