Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code to pre-validate at 'FunctionLoadRequest' and officially support entrypoint #116

Merged
merged 4 commits into from
Dec 14, 2018
Merged

Refactor the code to pre-validate at 'FunctionLoadRequest' and officially support entrypoint #116

merged 4 commits into from
Dec 14, 2018

Conversation

daxian-dbw
Copy link
Contributor

  • Refactor the code to do initialization in a more organized way.
  • Pre-validate the script against the function metadata when loading a 'FunctionLoadRequest'.
  • Support EntryPoint only when ScriptFile points to a .psm1; support .psm1 script file only when EntryPoint is specified.
  • Add unit tests and e2e tests

Fix #15, #101, #73

TylerLeonhardt
TylerLeonhardt reviewed Dec 14, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more-or-less looks good - just have some questions

src/FunctionLoader.cs Outdated Show resolved Hide resolved
src/FunctionLoader.cs Outdated Show resolved Hide resolved
src/FunctionLoader.cs Outdated Show resolved Hide resolved
src/PowerShell/PowerShellManager.cs Outdated Show resolved Hide resolved
src/PowerShell/PowerShellManager.cs Show resolved Hide resolved
test/Unit/Function/FunctionLoaderTests.cs Show resolved Hide resolved
test/Unit/Function/FunctionLoaderTests.cs Show resolved Hide resolved
test/Unit/Function/FunctionLoaderTests.cs Show resolved Hide resolved
test/Unit/Function/FunctionLoaderTests.cs Show resolved Hide resolved
test/Unit/PowerShell/TestScripts/testBasicFunctionWithTriggerMetadata.ps1 Outdated Show resolved Hide resolved
TylerLeonhardt
TylerLeonhardt approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for also adding the other whitespace for the calls to .AddParameter 😄

@daxian-dbw daxian-dbw merged commit 5393e14 into dev Dec 14, 2018
@daxian-dbw daxian-dbw deleted the entrypoint branch December 14, 2018 21:49
This was referenced Jan 4, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daxian-dbw @TylerLeonhardt