Moving Dapr bindings and triggers to FunctionApp and getting rid of DaprFunctionApp #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aprFunctionApp Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
ASHIQUEMD
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
…aprFunctionApp Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
…aprFunctionApp Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Codecov Report
@@ Coverage Diff @@
## dev #191 +/- ##
==========================================
- Coverage 91.27% 91.25% -0.03%
==========================================
Files 58 57 -1
Lines 3415 3406 -9
Branches 847 847
==========================================
- Hits 3117 3108 -9
Misses 220 220
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gavin-aguiar
approved these changes
Oct 2, 2023
vrdmr
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Dapr Extension Python library to be part of FunctionApp class instead of DaprFunctionApp. This will make the dapr usage seamless with other functions binding and triggers. This will also keep the existing user not change to any other class and use the existing FunctionApp for Dapr bindings and trigger.