Naive implementation of a backwards-compatible function_name decorator
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #202 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 56 56
Lines 3243 3243
Branches 665 665
=======================================
Hits 3019 3019
Misses 137 137
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidmrdavid
force-pushed
the
dajusto/backwards-compat
branch
from
5874780
to
cf6a425
Compare
davidmrdavid
changed the title
function_namefunction_name decorator
davidmrdavid
commented
Jan 12, 2024
Comment on lines
+493
to
+495
| class LegacyBluePrint(TriggerApi, BindingApi): | ||
| pass | ||
|
|
There was a problem hiding this comment.
notice this doesn't inherit from SettingsApi :)
|
Hi David @davidmrdavid , wonder what error customer has seen from this breaking change? and is this starting to happen just recently? |
|
@gavin-aguiar: I noticed the tests are failing, any ideas on what happened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (https://github.com/Azure/azure-functions-python-library/pulls?q=is%3Apr+is%3Aclosed+settingsapi) seems to have made a breaking change prevent DF BluePrints from using the
function_namedecorator in versions < 1.2.8 ofazure-functions-durable.This PR mitigates that breaking change by creating a backwards compatibility layer that allows anything that inherits from
TriggerAPIto continue usingfunction_name. I also keep the implementation ofSettingsApi'sfunction_nameto be the same as thisTriggerAPIbackwards compat layer by unifying the implementations under a_function_nameprivate method inherited fromDecoratorAPI. The approach isn't perfect, but I think it's sufficiently clean given the circumstances.I also added a test to validate this worked