Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fixes #204

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Unit tests fixes #204

merged 9 commits into from
Jan 31, 2024

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Jan 31, 2024

3 tests started failing with

=========================== short test summary info ============================
ERROR tests/decorators/test_dapr.py
ERROR tests/decorators/test_decorators.py
ERROR tests/decorators/test_function_app.py

E ModuleNotFoundError: No module named 'tests'

Changes:

  • Adding a python -m pytests to the CI pipeline fixed this issue.
  • Removed python -m pip install pytest-cov from ci pipeline since its already in .[dev]
  • Merged testsutils files and moved it to utils directory

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a43888) 93.09% compared to head (04caf39) 93.09%.

❗ Current head 04caf39 differs from pull request most recent head 41294dc. Consider uploading reports for the commit 41294dc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #204   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          56       56           
  Lines        3243     3243           
  Branches      665      665           
=======================================
  Hits         3019     3019           
  Misses        137      137           
  Partials       87       87           
Flag Coverage Δ
unittests 93.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavin-aguiar gavin-aguiar merged commit 32ae79a into dev Jan 31, 2024
12 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/test_fixes branch January 31, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants