DurableClient Converter #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-library into hallvictoria/durable-converter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #206 +/- ##
=======================================
Coverage 93.09% 93.10%
=======================================
Files 56 56
Lines 3243 3247 +4
Branches 665 666 +1
=======================================
+ Hits 3019 3023 +4
Misses 137 137
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hallvictoria
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
nytian
approved these changes
Mar 6, 2024
gavin-aguiar
approved these changes
Mar 6, 2024
davidmrdavid
pushed a commit
that referenced
this pull request
Mar 11, 2024
* sample durableClient converter * dc converter & test * lint * removed unnecessary funcs * typo --------- Co-authored-by: Victoria Hall <victoria.hall@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a DurableClient converter class based off of the Generic converter type so that DurableClient is no longer a generic type. Only function needed was has_implicit_output