Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Asgi Path Param Encoding change to utf-8 #208

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

YunchuWang
Copy link
Contributor

@YunchuWang YunchuWang commented Mar 8, 2024

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (31f3d42) to head (a62c126).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #208   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          56       56           
  Lines        3247     3247           
  Branches      666      666           
=======================================
  Hits         3023     3023           
  Misses        137      137           
  Partials       87       87           
Flag Coverage Δ
unittests 93.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fredrike fredrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use unicode literals to avoid further errors.

tests/test_http_wsgi.py Outdated Show resolved Hide resolved
tests/test_http_wsgi.py Outdated Show resolved Hide resolved
YunchuWang and others added 3 commits April 12, 2024 08:21
Co-authored-by: Fredrik Erlandsson <fredrik.e@gmail.com>
Co-authored-by: Fredrik Erlandsson <fredrik.e@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (31f3d42) to head (a62c126).
Report is 1 commits behind head on dev.

❗ Current head a62c126 differs from pull request most recent head 231ecfe. Consider uploading reports for the commit 231ecfe to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #208   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          56       56           
  Lines        3247     3247           
  Branches      666      666           
=======================================
  Hits         3023     3023           
  Misses        137      137           
  Partials       87       87           
Flag Coverage Δ
unittests 93.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YunchuWang YunchuWang merged commit 5a9360b into dev Apr 12, 2024
13 checks passed
@YunchuWang YunchuWang deleted the wangbill/fix-asgi-encoding branch April 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] latin-1 encoding of route_params in AsgiMiddleware
4 participants