Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp in the received invocation logs #1378

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Dec 6, 2023

Description

Added a UTC timestamp to the received invocation logs. Edited tests to check for updated log format.

Fixes #1337


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f269c09) 85.81% compared to head (916056b) 85.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1378      +/-   ##
==========================================
- Coverage   85.81%   85.31%   -0.50%     
==========================================
  Files          35       35              
  Lines        1953     1955       +2     
  Branches      370      370              
==========================================
- Hits         1676     1668       -8     
- Misses        208      215       +7     
- Partials       69       72       +3     
Flag Coverage Δ
unittests 85.26% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review December 8, 2023 18:29
@hallvictoria hallvictoria merged commit 0337cb7 into dev Dec 11, 2023
52 of 53 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/invocation-timestamp branch December 11, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add timestamp in the received invocation logs
2 participants