Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Settings Logs formatting fixes #1387

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

hallvictoria
Copy link
Contributor

Description

Added space and delimiter for parsing. Logs now look like below:
image

Fixes https://github.com/Azure/azure-functions-pyfx-planning/issues/99


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0337cb7) 85.93% compared to head (6394974) 85.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1387      +/-   ##
==========================================
- Coverage   85.93%   85.11%   -0.82%     
==========================================
  Files          35       35              
  Lines        1955     1955              
  Branches      370      370              
==========================================
- Hits         1680     1664      -16     
- Misses        207      217      +10     
- Partials       68       74       +6     
Flag Coverage Δ
unittests 85.06% <ø> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review January 2, 2024 18:53
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! :)

LGTM

@hallvictoria hallvictoria merged commit 9ae1d62 into dev Jan 11, 2024
52 of 53 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/appsetting-logs-formatting branch January 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants