Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Speedscope format to profiling pipeline #1405

Merged
merged 13 commits into from
Jan 23, 2024

Conversation

YunchuWang
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@YunchuWang
Copy link
Contributor Author

/profile

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1143e9) 85.46% compared to head (901147a) 85.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1405   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          35       35           
  Lines        1968     1968           
  Branches      370      370           
=======================================
  Hits         1682     1682           
  Misses        213      213           
  Partials       73       73           
Flag Coverage Δ
unittests 85.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YunchuWang YunchuWang changed the base branch from Resolve-github-actions-permission-breaking-change to dev January 23, 2024 02:31
@YunchuWang YunchuWang changed the title Update perf-testing-setup.yml Support Speedscope format to profiling pipeline Jan 23, 2024
@YunchuWang YunchuWang marked this pull request as ready for review January 23, 2024 02:38
@YunchuWang YunchuWang merged commit 41005e6 into dev Jan 23, 2024
44 of 49 checks passed
@YunchuWang YunchuWang deleted the add-speedscope-to-profiling-pipeline branch January 23, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants