Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unit and docker tests #1438

Merged
merged 13 commits into from
Mar 5, 2024
Merged

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Feb 29, 2024

Description

Fixes: flaky stein tests, flaky dispatcher tests, filename docker tests

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (7de7724) to head (a6528ce).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1438      +/-   ##
==========================================
- Coverage   85.44%   85.19%   -0.26%     
==========================================
  Files          35       35              
  Lines        1965     1965              
  Branches      370      370              
==========================================
- Hits         1679     1674       -5     
- Misses        213      217       +4     
- Partials       73       74       +1     
Flag Coverage Δ
unittests 85.13% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria changed the title fixed invalid stein tests Fixed invalid stein tests Feb 29, 2024
@hallvictoria hallvictoria marked this pull request as ready for review February 29, 2024 17:04
@gavin-aguiar
Copy link
Contributor

@hallvictoria hallvictoria reopened this Mar 1, 2024
@hallvictoria hallvictoria changed the title Fixed invalid stein tests Fixed unit and docker tests Mar 5, 2024
@hallvictoria hallvictoria merged commit 2e91fa1 into dev Mar 5, 2024
70 of 71 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/invalid-stein-tests branch March 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants