Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update function directory in load request to use /home/site/wwwroot #1480

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Apr 17, 2024

Description

This fixes a bug introduced in #1446.

For function apps using FWPC > 1 and using blueprints, the second worker does not get the metadata request. In the load request, the worker uses the function directory sent from the host. This works for functions apps without blueprints since the func dir is always /home/site/wwwroot. For blueprints, the function dir is /home/site/wwwroot/<blueprint_dir>. So in the load request, the worker tries to find function_app.py in /home/site/wwwroot/<blueprint_dir> and it fails indexing.
Fix is to always use /home/site/wwwroot for v2 programming model

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@gavin-aguiar gavin-aguiar marked this pull request as ready for review April 17, 2024 20:11
@gavin-aguiar gavin-aguiar changed the title Gaaguiar/hotfix 433 fix: Update function directory in load request to use /home/site/wwwroot Apr 17, 2024
@vrdmr vrdmr changed the base branch from dev to release/4.27.1 April 17, 2024 21:08
@vrdmr vrdmr changed the base branch from release/4.27.1 to dev April 17, 2024 21:08
@gavin-aguiar gavin-aguiar changed the base branch from dev to release/4.27.1 April 17, 2024 21:15
@gavin-aguiar gavin-aguiar changed the base branch from release/4.27.1 to dev April 17, 2024 21:16
@gavin-aguiar gavin-aguiar merged commit 6587898 into dev Apr 18, 2024
51 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/hotfix_433 branch April 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants