Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up dev branch to be the v4 branch #914

Closed
wants to merge 1 commit into from
Closed

Setting up dev branch to be the v4 branch #914

wants to merge 1 commit into from

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Nov 16, 2021

Description

Migrating dev branch to work for v4 version of the Functions.

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr marked this pull request as draft November 16, 2021 08:45
@vrdmr vrdmr mentioned this pull request Nov 16, 2021
Closed
5 tasks
@vrdmr vrdmr force-pushed the vameru/ready-v4-and-py310 branch 2 times, most recently from ced2c43 to 7d2a194 Compare November 16, 2021 09:13
arroyc
arroyc reviewed Nov 23, 2021
View reviewed changes
.flake8 Show resolved Hide resolved
@vrdmr
Copy link
Member Author

vrdmr commented Jan 30, 2022

Closing this in favor of #936.

@vrdmr vrdmr closed this Jan 30, 2022
@vrdmr vrdmr deleted the vameru/ready-v4-and-py310 branch March 3, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arroyc arroyc arroyc left review comments

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang YunchuWang will be requested when the pull request is marked ready for review YunchuWang is a code owner

@pdthummar pdthummar Awaiting requested review from pdthummar pdthummar will be requested when the pull request is marked ready for review pdthummar is a code owner

@hallvictoria hallvictoria Awaiting requested review from hallvictoria hallvictoria will be requested when the pull request is marked ready for review hallvictoria is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrdmr @arroyc