Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retry logic to Azure Function output binding for transient mode #293

Open
vicancy opened this issue Oct 10, 2023 · 0 comments
Open

Comments

@vicancy
Copy link
Member

vicancy commented Oct 10, 2023

It is possible that REST API calls to Azure SignalR service failed with intermittent 5xx errors, and retry can success. Customers using output binding has no easy way to retry sending by themselves, we could add retry logic into output binding for 5xx errors for better user experience.

Y-Sindo added a commit to Azure/azure-signalr that referenced this issue Oct 19, 2023
Add retry capability to REST client to handle transient errors. Tracking issue: Azure/azure-functions-signalrservice-extension#293

## Add two retry modes:
1. Fixed delay
3. Exponential backoff delay (Do we need to add jitter to the delay?)

## For message APIs:
Only the situations when HTTP status code > 500  are safe to retry.
For 500 error, runtime returns 500 when timeout, so it's not safe to retry.

## For non-message APIs:
The following situations are considered to be transient:
1. HTTP response status code 5xx or 408(Request timeout).
2. Request timeout with the timeout length configured as `ServiceManagerOptions.HttpClientTimeout`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant