Add Azure Function Java support binding library #48
Conversation
JialinXin
requested review from
chenkennt,
anthonychu,
zackliu,
pragnagopa and
jdneo
...c/main/java/com/microsoft/azure/functions/signalr/annotation/SignalRConnectionInfoInput.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/microsoft/azure/functions/signalr/annotation/SignalRConnectionInfoInput.java
Outdated
Show resolved
Hide resolved
...brary/java/src/main/java/com/microsoft/azure/functions/signalr/annotation/SignalROutput.java
Outdated
Show resolved
Hide resolved
binding-library/java/pom.xml
Outdated
|
|
||
| <groupId>com.microsoft.azure.functions</groupId> | ||
| <artifactId>azure-functions-java-library-signalr</artifactId> | ||
| <version>1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
1.0-SNAPSHOT [](start = 4, length = 31)
Will use 1.0.0 as release version.
There was a problem hiding this comment.
Please change to 1.0.0-SNAPSHOT
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>com.microsoft.azure.functions</groupId> | ||
| <artifactId>azure-functions-java-library-signalr</artifactId> |
There was a problem hiding this comment.
@pragnagopa Would you help check if the groupId is good?
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <azure.functions.java.library.version>1.3.0-SNAPSHOT</azure.functions.java.library.version> |
There was a problem hiding this comment.
1.3.0-SNAPSHOT [](start = 46, length = 14)
Will update to release version(should be 1.3.0) after library published and before checked-in.
There was a problem hiding this comment.
It would be good to release a SNAPSHOT version first to enable E2E testing before releasing the official version. This is the same release process we follow of the library #Resolved
There was a problem hiding this comment.
| /** | ||
| * User to add to or remove from group | ||
| */ | ||
| public String userId = ""; |
There was a problem hiding this comment.
How is this used? Can you please add test/sample code?
There was a problem hiding this comment.
Check sample here: https://github.com/Azure/azure-functions-signalrservice-extension/pull/49/files. Do you suggest to add sample as comments in this file?
In reply to: 259940432 [](ancestors = 259940432)
| * @since 1.0.0 | ||
| */ | ||
| public class SignalRMessage { | ||
| /** |
There was a problem hiding this comment.
Same here. How is this used? Can you please add test/sample code?
| public @interface SignalROutput { | ||
| /** | ||
| * The variable name used in function.json. | ||
| * @return The variable name used in function.json. |
There was a problem hiding this comment.
@anthonychu - Have you tested this? I would like to make sure there are no changes needed for this work on the worker.
There was a problem hiding this comment.
With help from Anthony, I've tested this. By replacing worker(build from dev branch) in the function core tools and latest maven plugin, it could work. Sample code can be found in this PR: https://github.com/Azure/azure-functions-signalrservice-extension/pull/49/files
In reply to: 259940994 [](ancestors = 259940994)
binding-library/java/README.md
Outdated
|
|
||
| # Contributing | ||
|
|
||
| This project welcomes contributions and suggestions. Most contributions require you to agree to a |
With limitation from KoreBuild, the folder structure is not able to change. Add a binding-library folder under root to manage other language supports.
Sample update will be in another PR.