replace read async with read of SqlReader for perf

.vscode/settings.json

@@ -8,6 +8,6 @@
     "omnisharp.enableEditorConfigSupport": true,
     "omnisharp.enableRoslynAnalyzers": true,
     "yaml.schemas": {
-        "https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/master/service-schema.json": "builds/azure-pipelines/**/*.yml"
-    },
+         "https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/master/service-schema.json": "builds/azure-pipelines/**/*.yml"
+     },
 }

Directory.Packages.props

@@ -4,8 +4,8 @@
     <PackageVersion Include="Microsoft.Azure.WebJobs.Extensions.Storage" Version="5.0.1" />
     <PackageVersion Include="Microsoft.NET.Sdk.Functions" Version="4.1.3" />
     <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.1.0" />
+    <PackageVersion Include="Microsoft.Azure.WebJobs" Version="3.0.36" />
     <PackageVersion Include="Microsoft.ApplicationInsights" Version="2.21.0" />
-    <PackageVersion Include="Microsoft.Azure.WebJobs" Version="3.0.33" />
     <PackageVersion Include="Microsoft.Data.SqlClient" Version="5.0.1" />
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
     <PackageVersion Include="morelinq" Version="3.3.2" />
@@ -15,6 +15,7 @@
     <PackageVersion Include="Moq" Version="4.18.2" />
     <PackageVersion Include="xunit" Version="2.4.2" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5" />
+    <PackageVersion Include="xRetry" Version="1.9.0" />
     <PackageVersion Include="Microsoft.Azure.WebJobs.Script.ExtensionsMetadataGenerator" Version="4.0.1" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.2" />
     <PackageVersion Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
@@ -28,5 +29,6 @@
     <PackageVersion Include="Microsoft.AspNetCore.Mvc.Core" Version="2.2.5" />
     <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="6.0.1" />
     <PackageVersion Include="Microsoft.SqlServer.TransactSql.ScriptDom" Version="161.8817.2" />
+    <PackageVersion Include="Grpc.Net.Client" Version="2.55.0"/>
   </ItemGroup>
 </Project>

README.md

@@ -1,13 +1,14 @@
-# Azure SQL bindings for Azure Functions
+# Azure SQL bindings for Azure Functions - Preview
 
 ## Table of Contents
 
-- [Azure SQL bindings for Azure Functions](#azure-sql-bindings-for-azure-functions)
+- [Azure SQL bindings for Azure Functions - Preview](#azure-sql-bindings-for-azure-functions---preview)
   - [Table of Contents](#table-of-contents)
   - [Introduction](#introduction)
   - [Supported SQL Server Versions](#supported-sql-server-versions)
   - [Known Issues](#known-issues)
     - [Output Bindings](#output-bindings)
+    - [Trigger Bindings](#trigger-bindings)
   - [Telemetry](#telemetry)
   - [Trademarks](#trademarks)
 
@@ -17,7 +18,7 @@ This repository contains the Azure SQL bindings for Azure Functions extension co
 
 - **Input Binding**: takes a SQL query or stored procedure to run and returns the output to the function.
 - **Output Binding**: takes a list of rows and upserts them into the user table (i.e. If a row doesn't already exist, it is added. If it does, it is updated).
-- **Trigger (preview)**: monitors the user table for changes (i.e., row inserts, updates, and deletes) and invokes the function with updated rows. Note: This is a preview feature and is available only in preview packages. More information is available on the [trigger branch](https://github.com/Azure/azure-functions-sql-extension/tree/release/trigger) and on the [documentation](https://aka.ms/sqltrigger).
+- **Trigger Binding**: monitors the user table for changes (i.e., row inserts, updates, and deletes) and invokes the function with updated rows.
 
 For a more detailed overview of the different types of bindings see the [Bindings Overview](https://github.com/Azure/azure-functions-sql-extension/blob/main/docs/BindingsOverview.md).
 
@@ -42,7 +43,7 @@ Databases on SQL Server, Azure SQL Database, or Azure SQL Managed Instance which
 
 > **Note:** While we are actively working on resolving these issues, some may not be supported at this time. We appreciate your patience as we work to improve the Azure Functions SQL Extension.
 
-- **By Design:** The table used by a SQL binding cannot contain two columns that only differ by casing (Ex. 'Name' and 'name').
+- **By Design:** The table used by a SQL binding or SQL trigger cannot contain two columns that only differ by casing (Ex. 'Name' and 'name').
 - **By Design:** Non-CSharp functions using SQL bindings against tables with columns of data types `BINARY` or `VARBINARY` need to map those columns to a string type. Input bindings will return the binary value as a base64 encoded string. Output bindings require the value upserted to binary columns to be a base64 encoded string.
 - **Planned for Future Support:** SQL bindings against tables with columns of data types `GEOMETRY` and `GEOGRAPHY` are not supported. Issue is tracked [here](https://github.com/Azure/azure-functions-sql-extension/issues/654).
 - Issues resulting from upstream dependencies can be found [here](https://github.com/Azure/azure-functions-sql-extension/issues?q=is%3Aopen+is%3Aissue+label%3Aupstream).
@@ -63,6 +64,10 @@ Databases on SQL Server, Azure SQL Database, or Azure SQL Managed Instance which
   - PowerShell: The workaround is to use the `$TriggerMetadata[$keyName]` to retrieve the query property - an example can be found [here](https://github.com/Azure/azure-functions-sql-extension/blob/main/samples/samples-powershell/AddProductParams/run.ps1). Issue is tracked [here](https://github.com/Azure/azure-functions-powershell-worker/issues/895).
   - Python: The workaround is to use `parse_qs` - an example can be found [here](https://github.com/Azure/azure-functions-sql-extension/blob/main/samples/samples-python/AddProductParams/__init__.py). Issue is tracked [here](https://github.com/Azure/azure-functions-python-worker/issues/894).
 
+### Trigger Bindings
+
+- **By Design:** Trigger bindings will exhibit undefined behavior if the SQL table schema gets modified while the user application is running, for example, if a column is added, renamed or deleted or if the primary key is modified or deleted. In such cases, restarting the application should help resolve any errors.
+
 ## Telemetry
 
 This extension collects usage data in order to help us improve your experience. The data is anonymous and doesn't include any personal information. You can opt-out of telemetry by setting the `AZUREFUNCTIONS_SQLBINDINGS_TELEMETRY_OPTOUT` environment variable or the `AzureFunctionsSqlBindingsTelemetryOptOut` app setting (in your `*.settings.json` file) to '1', 'true' or 'yes';

Worker.Extensions.Sql/src/SqlChange.cs

@@ -0,0 +1,45 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+namespace Microsoft.Azure.Functions.Worker.Extensions.Sql
+{
+    /// <summary>
+    /// Represents the changed row in the user table.
+    /// </summary>
+    /// <typeparam name="T">POCO class representing the row in the user table</typeparam>
+    public sealed class SqlChange<T>
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SqlChange{T}"/> class.
+        /// </summary>
+        /// <param name="operation">Change operation</param>
+        /// <param name="item">POCO representing the row in the user table on which the change operation took place</param>
+        public SqlChange(SqlChangeOperation operation, T item)
+        {
+            this.Operation = operation;
+            this.Item = item;
+        }
+
+        /// <summary>
+        /// Change operation (insert, update, or delete).
+        /// </summary>
+        public SqlChangeOperation Operation { get; }
+
+        /// <summary>
+        /// POCO representing the row in the user table on which the change operation took place. If the change
+        /// operation is <see cref="SqlChangeOperation.Delete" />, then only the properties corresponding to the primary
+        /// keys will be populated.
+        /// </summary>
+        public T Item { get; }
+    }
+
+    /// <summary>
+    /// Represents the type of change operation in the table row.
+    /// </summary>
+    public enum SqlChangeOperation
+    {
+        Insert,
+        Update,
+        Delete
+    }
+}

Worker.Extensions.Sql/src/SqlTriggerAttribute.cs

@@ -0,0 +1,49 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System;
+using Microsoft.Azure.Functions.Worker.Extensions.Abstractions;
+
+namespace Microsoft.Azure.Functions.Worker.Extensions.Sql
+{
+    public sealed class SqlTriggerAttribute : TriggerBindingAttribute
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SqlTriggerAttribute"/> class, which triggers the function when any changes on the specified table are detected.
+        /// </summary>
+        /// <param name="tableName">Name of the table to watch for changes.</param>
+        /// <param name="connectionStringSetting">The name of the app setting where the SQL connection string is stored</param>
+        /// <param name="leasesTableName">Optional - The name of the table used to store leases. If not specified, the leases table name will be Leases_{FunctionId}_{TableId}</param>
+        public SqlTriggerAttribute(string tableName, string connectionStringSetting, string leasesTableName = null)
+        {
+            this.TableName = tableName ?? throw new ArgumentNullException(nameof(tableName));
+            this.ConnectionStringSetting = connectionStringSetting ?? throw new ArgumentNullException(nameof(connectionStringSetting));
+            this.LeasesTableName = leasesTableName;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SqlTriggerAttribute"/> class with null value for LeasesTableName.
+        /// </summary>
+        /// <param name="tableName">Name of the table to watch for changes.</param>
+        /// <param name="connectionStringSetting">The name of the app setting where the SQL connection string is stored</param>
+        public SqlTriggerAttribute(string tableName, string connectionStringSetting) : this(tableName, connectionStringSetting, null) { }
+
+        /// <summary>
+        /// Name of the app setting containing the SQL connection string.
+        /// </summary>
+        public string ConnectionStringSetting { get; }
+
+        /// <summary>
+        /// Name of the table to watch for changes.
+        /// </summary>
+        public string TableName { get; }
+
+        /// <summary>
+        /// Name of the table used to store leases.
+        /// If not specified, the leases table name will be Leases_{FunctionId}_{TableId}
+        /// More information on how this is generated can be found here
+        /// https://github.com/Azure/azure-functions-sql-extension/blob/release/trigger/docs/TriggerBinding.md#az_funcleasestablename
+        /// </summary>
+        public string LeasesTableName { get; }
+    }
+}

builds/azure-pipelines/build-release-java.yml

@@ -25,7 +25,7 @@ steps:
       $source = 'java-library'
       $destination = '$(Build.ArtifactStagingDirectory)/java-library'
       $jar = Get-ChildItem $source/target/*.jar | Select-Object -First 1 | Select Name
-      $jar -match '\d+\.\d+\.\d+'
+      $jar -match '\d+\.\d+\.\d+(-preview)?'
       $version = $matches[0]
       $prefix = 'azure-functions-java-library-sql-'+$version
       New-Item $destination -ItemType Directory

builds/azure-pipelines/build-release.yml

@@ -4,7 +4,7 @@ parameters: # parameters are shown up in ADO UI in a build queue time
 - name: 'ReleaseType'
   displayName: 'Type of release'
   type: string
-  default: full
+  default: preview
   values:
     - full
     - preview
@@ -22,7 +22,7 @@ schedules:
 variables:
   solution: '**/*.sln'
   configuration: 'Release'
-  versionMajor: 2
+  versionMajor: 3
   versionMinor: 0
   versionMajorMinor: '$(versionMajor).$(versionMinor)'  # This variable is only used for the counter so we reset properly when either major or minor is bumped
   versionPatch: $[counter(variables['versionMajorMinor'], 0)] # This will reset when we bump minor version

builds/azure-pipelines/performance.yml

@@ -2,7 +2,13 @@ trigger: none
 
 pr: none
 
-schedules: [ ]
+schedules:
+  - cron: "0 0 * * *"
+    displayName: Mon-Fri at Midnight
+    branches:
+      include:
+        - release/trigger
+    always: true
 
 variables:
   configuration: 'Release'

builds/azure-pipelines/template-steps-performance.yml

@@ -9,6 +9,11 @@ parameters:
     default:
       - input
       - output
+      - trigger
+      - trigger_batch
+      - trigger_poll
+      - trigger_overrides
+      - trigger_parallel
 
 steps:
 - task: UseDotNet@2