Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet isolated fsharp templates #1074

Merged
merged 14 commits into from Dec 14, 2021

Conversation

aaronpowell
Copy link

This adds project and item templates for F# under the dotnet-isolated project model.

The item templates match what originally existed for F#, so there are a few gaps still compared to the C# templates, but this brings the dotnet-isolated experience up to where we were with the in process model for F# dev.

@dsyme
Copy link
Member

dsyme commented Aug 10, 2021

This is fantastic, it will be so good to have the templates supported

@mabasic
Copy link

mabasic commented Sep 14, 2021

Will this be in the v4 and in v3, or just v4?

@joshuapassos
Copy link

Anything holding this back from being merged?

@aaronpowell
Copy link
Author

Will this be in the v4 and in v3, or just v4?

It's possible that this could be back ported to the v3 branch, but I created it against v4 as that's the currently active dev branch.

Anything holding this back from being merged?

Just waiting for review from someone on the Functions team. @soninaren @fabiocav would either of you have time to review this?

@ghost ghost removed the Needs: Author feedback label Oct 11, 2021
@aaronpowell
Copy link
Author

@soninaren anything more outstanding on these that you'd like me to address?

@soninaren
Copy link
Member

@aaronpowell, Looks like your original changes were correct. I will merge and sync your template changes with c#.

@fabiocav
Copy link
Member

@soninaren your last comment here was a while ago. Is there a reason why this hasn't been merged yet? Can we please have this in ASAP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants