fixing publish for v2 apps with .NET Core 3 SDK installed #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
reviewed
Dec 11, 2019
src/Microsoft.NET.Sdk.Functions.MSBuild/Targets/Microsoft.NET.Sdk.Functions.Version.props
Outdated
Show resolved
Hide resolved
brettsam
force-pushed
the
brettsam/publishv2
branch
from
a264d4b
to
d0d350b
Compare
brettsam
force-pushed
the
brettsam/publishv2
branch
from
d0d350b
to
24fa35d
Compare
fabiocav
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
This is a port of #354 for the 1.0 release. If .NET Core 3 SDK is installed, the targets used are different and we were missing this step in this case. I tested this with targeting the 2.2 SDK as well and it continued to work (this target won't get hit in that scenario).