Fixing deployment status response parsing #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
commented
May 25, 2022
| @@ -13,7 +13,7 @@ | |||
| <PackageReference Include="Newtonsoft.Json" Version="[11.0.2]" /> | |||
| <PackageReference Include="System.Runtime.Handles" Version="4.3.0" /> | |||
| <PackageReference Include="System.IO.FileSystem.Primitives" Version="4.3.0" /> | |||
| <PackageReference Include="Mono.Cecil" Version="0.11.1" /> | |||
| <PackageReference Include="Mono.Cecil" Version="0.11.3" /> | |||
There was a problem hiding this comment.
Unrelated, but had to update to address a build issue.
brettsam
approved these changes
May 25, 2022
vijayrkn
approved these changes
May 25, 2022
|
@fabiocav - I am assuming you will cherry-pick to the v3.0 branch as well right? |
@vijayrkn yes. Wanted to go through the review here first and once settled/approved, cherry pick to 3.0. Will go ahead and do that now. |
fabiocav
added a commit
that referenced
this pull request
May 25, 2022
fabiocav
added a commit
that referenced
this pull request
May 25, 2022
|
Microsoft.NET.Sdk.Functions version 4.1.1 is live in nuget gallery now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #556
This change is in response to a change in the API payload that broke the assumption made in the original implementation. The actual change was the introduction of a new
build_summaryproperty that carried a JSON object instead of a simple string value, causing a deserialization exception in the updated code path.