Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get username either by IMDS or from a local OVF file #100

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Get username either by IMDS or from a local OVF file #100

merged 3 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. Get username either by IMDS or from a local OVF file 

    Username can be obtained either via fetching instance metadata from IMDS
or mounting a local device for OVF environment file. It should not fail
immediately in a single failure, instead it should fall back to the other
mechanism. So it is not a good idea to use `?` for query() or
get_environment().

Explicitly get instance metadata to handle error of missing instance metadata
before dealing with setting ssh keys or hostname.
    @dongsupark
    dongsupark committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3b65ba3 View commit details
    Browse the repository at this point in the history

  2. tests: pass in security type when creating VM 

    When running functional tests, pass in --security-type, usually
`TrustedLaunch`, which is nowadays the default for most VMs.
It is still possible to override the security type by passing in
an environment variable $VM_SECURITY_TYPE, like `Standard`.
    @dongsupark
    dongsupark committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7647114 View commit details
    Browse the repository at this point in the history

  3. tests: address shellcheck warnings in functional_tests.sh

    @dongsupark
    dongsupark committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9f29a9a View commit details
    Browse the repository at this point in the history