Add GitHub Actions workflow ci.yaml #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address compiler warnings given by `cargo check` or `cargo build`.
Address coding style issues given by `cargo fmt`.
Address issues given by linter, `cargo clippy`. * remove unnecessary return. * remove unnecessary to_string. * remove comparison of bool with true/false * remove unnecessary reference * remove redundant use tokio * remove unnecessary let binding * remove empty strings in println!() * use vec![] macro instead of pushing values to a mutable Vec * use &str instead of &String to avoid creating a new object
Add new GitHub Actions workflow `ci.yaml`, which runs `cargo fmt`, `cargo build`, `cargo test`, and `cargo clippy`.
dongsupark
force-pushed
the
dongsu/github-actions-fmt-clippy
branch
from
4520480
to
91158c1
Compare
anhvoms
reviewed
Feb 6, 2024
| @@ -1,5 +1,7 @@ | |||
| # Azure Provisioning Agent | |||
|
|
|||
| [](https://github.com/Azure/azure-provisioning-agent/actions) | |||
There was a problem hiding this comment.
Can you add some note to README to indicate that all PRs should run cargo fmt, cargo clippy, and cargo tests before submission, otherwise CI will fail and merging will be blocked.
Better yet, we can add some target to the Makefile such as "make tests", "make lint", "make format" to assist with invoking the proper cargo steps during development/submitting PR
There was a problem hiding this comment.
Added notes to CONTRIBUTING.md.
Added makefile targets.
|
Ping, is there anything to be done? Can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address compiler warnings given by
cargo checkorcargo build.Address coding style issues given by
cargo fmt.Address issues given by linter,
cargo clippy.return.to_string.boolwithtrue/false.tokio.letbinding.println!().vec![]macro instead of pushing values to a mutableVec.&strinstead of&Stringto avoid creating a new object.Add new GitHub Actions workflow
ci.yaml, which runscargo fmt,cargo build,cargo test, andcargo clippy.Add GitHub CI status banner in
README.md.Testing done
cargo test,cargo fmt,cargo clippypassed.