Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure-Init: rename to azure-init #41

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Azure-Init: rename to azure-init #41

merged 1 commit into from
Feb 27, 2024

Conversation

t-lo
Copy link
Collaborator

@t-lo t-lo commented Feb 27, 2024

This change renames the project to azure-init. We also bump the version to 0.1.1 to signify the change.

@t-lo t-lo requested a review from dongsupark February 27, 2024 08:20
@dongsupark
Copy link
Collaborator

Looks like rustfmt failed. https://github.com/Azure/azure-init/actions/runs/8061656919/job/22019820491?pr=41

/home/runner/.cargo/bin/cargo fmt --all --check
Diff in /home/runner/work/azure-init/azure-init/src/goalstate.rs at line 45:
     let client = Client::new();
 
     let mut headers = HeaderMap::new();
-    headers.insert(
-        "x-ms-agent-name",
-        HeaderValue::from_static("azure-init"),
-    );
+    headers.insert("x-ms-agent-name", HeaderValue::from_static("azure-init"));
     headers.insert("x-ms-version", HeaderValue::from_static("2012-11-30"));
 
     let request = client.get(url).headers(headers);
Diff in /home/runner/work/azure-init/azure-init/src/goalstate.rs at line [7](https://github.com/Azure/azure-init/actions/runs/8061656919/job/22019820491?pr=41#step:5:8)4:
     let client = Client::new();
 
     let mut headers = HeaderMap::new();
-    headers.insert(
-        "x-ms-agent-name",
-        HeaderValue::from_static("azure-init"),
-    );
+    headers.insert("x-ms-agent-name", HeaderValue::from_static("azure-init"));
     headers.insert("x-ms-version", HeaderValue::from_static("2012-[11](https://github.com/Azure/azure-init/actions/runs/8061656919/job/22019820491?pr=41#step:5:12)-30"));
     headers.insert(
         "Content-Type",
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

@t-lo
Copy link
Collaborator Author

t-lo commented Feb 27, 2024

I see - was briefly distracted but now I'm on it. Thanks for the ping!

@t-lo
Copy link
Collaborator Author

t-lo commented Feb 27, 2024

AH! I see. Because the name is shorter (azure-provisioning-agent => azure-init) Rustfmt now wants all in a single line.
Fixed.

Copy link
Collaborator

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename azure-provisioning-agent.tgz to azure-init.tgz in .gitignore as well?

README.md Outdated
@@ -1,14 +1,14 @@
# Azure Provisioning Agent
# Azure-Init
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: blank at the end of line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

SUPPORT.md Outdated
@@ -6,13 +6,13 @@ There are no commercial support options available at this time.
## How to file issues and get help

This project uses GitHub Issues to track bugs and feature requests.
Please [search the existing issues](https://github.com/Azure/azure-provisioning-agent/issues) before filing new issues to avoid duplicates.
Please [search the existing issues](https://github.com/Azure/azure-init/issues) before filing new issues to avoid duplicates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^M at the end of line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - that's what I get for using the official SUPPORT.md example 😅

SUPPORT.md Outdated
For more general help and questions about using this project please [search our discussions](https://github.com/Azure/azure-provisioning-agent/discussions).
Feel free to [start a new discussion](https://github.com/Azure/azure-provisioning-agent/discussions/new/choose) if your topic has not been brought up.
For more general help and questions about using this project please [search our discussions](https://github.com/Azure/azure-init/discussions).
Feel free to [start a new discussion](https://github.com/Azure/azure-init/discussions/new/choose) if your topic has not been brought up.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^M at the end of 2 lines.

SUPPORT.md Outdated

## Microsoft Support Policy

Support for the Azure Provisioning Agent is limited to the resources listed above.
Support for the Azure-Init is limited to the resources listed above.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^M at the end of line.

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo t-lo merged commit 02ade86 into main Feb 27, 2024
2 checks passed
@t-lo t-lo deleted the t-lo/rename-azure-init branch February 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants