libazureinit: get mounted CDROM device at runtime #79
Conversation
|
CI fails because the |
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
a537d98
to
ca27650
Compare
|
Fixed the CI issue, it was easier than expected. |
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
e062f7a
to
1b2d322
Compare
|
Fixed a syntax error in clippy-linting, which was made by #78. |
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
1b2d322
to
61ca763
Compare
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
61ca763
to
b75cc2a
Compare
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
b75cc2a
to
17cd65a
Compare
| let ovf_body = mounted.read_ovf_env_to_string()?; | ||
| let environment = media::parse_ovf_env(ovf_body.as_str())?; | ||
| // list of CDROM devices that is available with possible filesystems. | ||
| let ovf_devices = media::get_mount_device()?; |
There was a problem hiding this comment.
consider decoupling the mount/ovf logic out of get_username()
is the cdrom only going to mounted if we detect password enabled via IMDS?
There was a problem hiding this comment.
Sounds like a good idea.
I would say, let's do that in another PR, because I don't want to leave the bug fixes in other commits unmerged for so long time. Ok?
There was a problem hiding this comment.
I agree it'd be good to move it out, and also that it's okay for it to be in another PR. I have a WIP branch tidying some of the APIs in this area anyway so I could probably add a commit moving things around here.
Get mounted device name of CDROM at runtime, instead of hard-coding /dev/sr0. Valid filesystems would include iso9660 and udf.
Install libudev-dev package in the default Ubuntu runner, as it is needed by block-utils Rust crate.
Fix syntax error in clippy-linting.yml, like "every step must define a `uses` or `run` key".
dongsupark
force-pushed
the
cdrom-mount-device
branch
from
17cd65a
to
ab601a9
Compare
Get mounted device name of CDROM at runtime, instead of hard-coding
/dev/sr0.Fixes #66
Testing done
TBD