Skip to content

Commit

Permalink
Updated device class for GWV2, Updated dependencies and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanann-ms committed Mar 19, 2024
1 parent 0768e40 commit 2bd7ee7
Show file tree
Hide file tree
Showing 15 changed files with 675 additions and 478 deletions.
1,095 changes: 650 additions & 445 deletions package-lock.json

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
{
"name": "azure-iothub",
"version": "1.16.4",
"version": "1.16.5",
"description": "Azure IoT SDK - IoT Hub",
"author": "Microsoft Corporation",
"license": "MIT",
"main": "iothub.js",
"typings": "iothub.d.ts",
"dependencies": {
"@azure/core-auth": "^1.4.0",
"@azure/identity": "^2.0.0",
"@azure/core-auth": "^1.7.0",
"@azure/identity": "^4.0.1",
"@azure/ms-rest-js": "^2.0.5",
"async": "^3.2.3",
"debug": "^4.3.1",
"getos": "^3.2.1",
"lodash": "^4.17.21",
"machina": "^4.0.2",
"rhea": "^1.0.15"
"rhea": "^1.0.15",
"ws": "^8.16.0"
},
"devDependencies": {
"@types/debug": "^4.1.5",
Expand Down
9 changes: 0 additions & 9 deletions src/device.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,6 @@ export class Device implements DeviceIdentity {

_.merge(this, userProps);
}

Object.defineProperty(this.authentication, 'SymmetricKey', {
enumerable: true,
get: function (): Device._SymmetricKey {
/*Codes_SRS_NODE_SERVICE_DEVICE_16_005: [The `authentication.SymmetricKey` property shall return the content of the `authentication.symmetricKey` property (the latter being the valid property returned by the IoT hub in the device description).]*/
return this.symmetricKey;
}
});
}
}

Expand All @@ -150,7 +142,6 @@ export namespace Device {

export interface Authentication {
// eslint-disable-next-line @typescript-eslint/naming-convention
SymmetricKey?: _SymmetricKey;
symmetricKey?: _SymmetricKey;
x509Thumbprint?: X509Thumbprints;
}
Expand Down
2 changes: 1 addition & 1 deletion test/_amqp_service_errors_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

const assert = require('chai').assert;
const errors = require('azure-iot-common').errors;
const errors = require('../dist/common-core/errors.js');
const translateError = require('../dist/amqp_service_errors.js').translateError;

describe('translateError', function () {
Expand Down
10 changes: 5 additions & 5 deletions test/_amqp_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ const sinon = require('sinon');
const EventEmitter = require('events').EventEmitter;
const Amqp = require('../dist/amqp.js').Amqp;
const assert = require('chai').assert;
const SharedAccessSignature = require('azure-iot-common').SharedAccessSignature;
const errors = require('azure-iot-common').errors;
const results = require('azure-iot-common').results;
const Message = require('azure-iot-common').Message;
const AmqpMessage = require('azure-iot-amqp-base').AmqpMessage;
const SharedAccessSignature = require('../dist/common-core/shared_access_signature.js').SharedAccessSignature;
const errors = require('../dist/common-core/errors.js');
const results = require('../dist/common-core/results.js');
const Message = require('../dist/common-core/message.js').Message;
const AmqpMessage = require('../dist/common-amqp/amqp_message.js').AmqpMessage;


const fakeConfig = {
Expand Down
2 changes: 1 addition & 1 deletion test/_amqp_ws_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const Amqp = require('../dist/amqp.js').Amqp;
const AmqpWs = require('../dist/amqp_ws.js').AmqpWs;
const assert = require('chai').assert;
const results = require('azure-iot-common').results;
const results = require('../dist/common-core/results.js');
const sinon = require('sinon');

describe('AmqpWs', function () {
Expand Down
4 changes: 2 additions & 2 deletions test/_client_common_testrun.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

const assert = require('chai').assert;
const Client = require('../dist/client.js').Client;
const errors = require('azure-iot-common').errors;
const Message = require('azure-iot-common').Message;
const errors = require('../dist/common-core/errors.js');
const Message = require('../dist/common-core/message.js').Message;
const debug = require('debug')('azure-iothub:_client_common_testrun');

function transportSpecificTests(opts) {
Expand Down
4 changes: 2 additions & 2 deletions test/_client_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const sinon = require('sinon');
const EventEmitter = require('events').EventEmitter;
const Amqp = require('../dist/amqp.js').Amqp;
const Client = require('../dist/client.js').Client;
const Message = require('azure-iot-common').Message;
const errors = require('azure-iot-common').errors;
const errors = require('../dist/common-core/errors.js');
const Message = require('../dist/common-core/message.js').Message;
const SimulatedAmqp = require('./amqp_simulated.js');
const transportSpecificTests = require('./_client_common_testrun.js');

Expand Down
2 changes: 1 addition & 1 deletion test/_connection_string_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

const assert = require('chai').assert;
const ArgumentError = require('azure-iot-common').errors.ArgumentError;
const ArgumentError = require('../dist/common-core/errors.js').ArgumentError;
const ConnectionString = require('../dist/connection_string.js');

const incompleteConnectionStrings = {
Expand Down
2 changes: 1 addition & 1 deletion test/_job_client_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const JobClient = require('../dist/job_client').JobClient;
const ConnectionString = require('../iothub').ConnectionString;
const SharedAccessSignature = require('../iothub').SharedAccessSignature;
const DeviceMethod = require('../dist/device_method').DeviceMethod;
const RestApiClient = require('azure-iot-http-base').RestApiClient;
const RestApiClient = require('../dist/common-http/rest_api_client').RestApiClient;
const Query = require('../dist/query').Query;

const defaultMaxExecutionTimeInSeconds = 3600;
Expand Down
2 changes: 1 addition & 1 deletion test/_registry_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const assert = require('chai').assert;
const sinon = require('sinon');
const uuid = require('uuid');
const versionQueryString = require('../dist/version').versionQueryString;
const errors = require('azure-iot-common').errors;
const errors = require('../dist/common-core/errors.js');
const Registry = require('../dist/registry.js').Registry;
const Twin = require('../dist/twin.js').Twin;
const Query = require('../dist/query.js').Query;
Expand Down
2 changes: 1 addition & 1 deletion test/_service_receiver_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
const EventEmitter = require('events').EventEmitter;
const assert = require('chai').assert;
const sinon = require('sinon');
const Message = require('azure-iot-common').Message;
const Message = require('../dist/common-core/message.js').Message;
const ServiceReceiver = require('../dist/service_receiver.js').ServiceReceiver;

describe('ServiceReceiver', function () {
Expand Down
2 changes: 1 addition & 1 deletion test/_shared_access_signature_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

const assert = require('chai').assert;
const ArgumentError = require('azure-iot-common').errors.ArgumentError;
const ArgumentError = require('../dist/common-core/errors.js').ArgumentError;
const SharedAccessSignature = require('../dist/shared_access_signature.js');

const incompleteSignatures = {
Expand Down
2 changes: 1 addition & 1 deletion test/_twin_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

const assert = require('chai').assert;
const sinon = require('sinon');
const errors = require('azure-iot-common').errors;
const errors = require('../dist/common-core/errors.js');
const Registry = require('../dist/registry.js').Registry;
const Twin = require('../dist/twin.js').Twin;

Expand Down
6 changes: 3 additions & 3 deletions test/amqp_simulated.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

'use strict';

const errors = require('azure-iot-common').errors;
const results = require('azure-iot-common').results;
const errors = require('../dist/common-core/errors.js');
const results = require('../dist/common-core/results.js');
const EventEmitter = require('events').EventEmitter;
const util = require('util');
const AmqpReceiver = require('azure-iot-amqp-base').AmqpReceiver;
const AmqpReceiver = require('../dist/common-amqp/receiver_link.js').ReceiverLink;

function SimulatedAmqp() {
EventEmitter.call(this);
Expand Down

0 comments on commit 2bd7ee7

Please sign in to comment.