Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve support bundle integration tests #176

Merged
merged 18 commits into from
Apr 10, 2024

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented Mar 27, 2024

This will mostly check names generated in the support bundle.

Plz test and send screenshots of errors.

My experience:
image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@digimaun digimaun self-assigned this Mar 28, 2024
@vilit1 vilit1 marked this pull request as ready for review April 1, 2024 20:49
@vilit1 vilit1 requested a review from digimaun as a code owner April 1, 2024 20:49
@vilit1
Copy link
Contributor Author

vilit1 commented Apr 10, 2024

image

Copy link
Member

@digimaun digimaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to confirm with you the behavior of this test suite in the following scenarios:

  • A resource that should be captured, is missing in the support bundle.
  • Support bundle has an extraneous/unexpected file.

How are those presented?

@vilit1
Copy link
Contributor Author

vilit1 commented Apr 10, 2024

Improved the errors here since AssertionError by itself is useless:
Missing replicaset:
image
image

Extra replicaset:
image
image

Missing and extra pods:
image
image

Other stuff (cause I thought this is also not the most obvious)
image
image

sanity check
image

@vilit1 vilit1 merged commit 86200ac into Azure:dev Apr 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants