Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use lower case cluster location for template clusterLocation #185

Merged
merged 1 commit into from
Apr 11, 2024
Merged

refactor: use lower case cluster location for template clusterLocation #185

merged 1 commit into from
Apr 11, 2024

Conversation

digimaun
Copy link
Member

@digimaun digimaun commented Apr 11, 2024 •
edited

  • As well as template location parameter if not provided.
  • Primary driver is usage of --template-file with the standard template which includes a lower cased allow list of locations. Pre-flight errors occur if the actual cluster location is of mixed case.

@digimaun digimaun marked this pull request as ready for review April 11, 2024 21:43
@digimaun digimaun merged commit 3e1b774 into Azure:dev Apr 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie4ever Elsie4ever Elsie4ever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@digimaun @Elsie4ever