Fixes QoS 2 persistence provider, Blob-based state persistence provid… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manusr, pls take a look. |
…er, SequenceNumber -> Packet Id conversion Motivation: Fix issues with Azure Storage-based persistence providers and sequence number conversion logic Modifications: - Azure Table QoS 2 persistence provider uses proper query API to retrieve only relevant row - QoS 2 persistence provider API is modified to work with SequenceNumber instead of MessageId -Azure Blob session state persistence provider is modified to update ETag value on in-memory session state object to allow saving it later on without any issue. - 14 least significant bits are used when converting SequenceNumber into PacketId - SequenceNumber type is changed to ulong. Result: - QoS 2 works - multiple SUBSCRIBE / UNSUBSCRIBE requests work within a single connection lifetime - generated Packet Id is conformant with MQTT spec
nayato
added a commit
that referenced
this pull request
Mar 12, 2016
Fixes QoS 2 persistence provider, Blob-based state persistence provid…
This was referenced Mar 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er, SequenceNumber -> Packet Id conversion
Motivation:
Fix issues with Azure Storage-based persistence providers and sequence number conversion logic
Modifications:
-Azure Blob session state persistence provider is modified to update ETag value on in-memory session state object to allow saving it later on without any issue.
Result: