Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there's a dll where an exe should be... #164

Merged
merged 1 commit into from
Jun 28, 2017
Merged

there's a dll where an exe should be... #164

merged 1 commit into from
Jun 28, 2017

Conversation

darobs
Copy link
Contributor

@darobs darobs commented Jun 21, 2017

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

@dcristoloveanu
Copy link
Member

    linkMqttLibrary(${theseTestsName}_dll)

I have to wonder why these are not passed with the ADDITIONAL_LIBS option of build_c_test_artifacts.
I guess this is so old that it was before the option was there...
Or maybe the option did not work?

If it would work this duplication would not exist and life would be rosier, wouldn't it :-)?


Refers to: iothub_client/tests/iothubclient_mqtt_ws_e2e/CMakeLists.txt:51 in 7f18d63. [](commit_id = 7f18d63, deletion_comment = False)

@dcristoloveanu
Copy link
Member

:shipit:

@az-iot-builder-01 az-iot-builder-01 merged commit 7f18d63 into Azure:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants