Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential size_t overflow in twin serializer #2567

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

vaavva
Copy link
Member

@vaavva vaavva commented Jan 25, 2024

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Integer wraparound, under-allocation, and heap buffer overflow in Azure IoT C SDK serializer_ingest() function

Description of the solution

Check if the size for allocation wraps around.

@vaavva vaavva merged commit 0030ea8 into main Jan 25, 2024
36 checks passed
@vaavva vaavva deleted the vaavva/serializer-overflow-fix branch January 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants