Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcheck for C SDK #2583

Merged
merged 26 commits into from
Mar 1, 2024
Merged

memcheck for C SDK #2583

merged 26 commits into from
Mar 1, 2024

Conversation

ericwol-msft
Copy link
Collaborator

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

ewertons
ewertons approved these changes Feb 29, 2024
View reviewed changes
iothub_client/src/iothubtransport_amqp_messenger.c Outdated Show resolved Hide resolved
iothub_client/src/iothubtransport_amqp_telemetry_messenger.c Outdated Show resolved Hide resolved
iothub_client/src/iothubtransport_amqp_twin_messenger.c Outdated Show resolved Hide resolved
serializer/inc/serializer_devicetwin.h Outdated Show resolved Hide resolved
ericwol-msft and others added 3 commits February 29, 2024 14:48
@ericwol-msft @ewertons
Update iothub_client/src/iothubtransport_amqp_messenger.c
66fb6ea 
Co-authored-by: Ewerton Scaboro da Silva <ewertons@microsoft.com>
@ericwol-msft @ewertons
Update iothub_client/src/iothubtransport_amqp_telemetry_messenger.c
f61d037 
Co-authored-by: Ewerton Scaboro da Silva <ewertons@microsoft.com>
@ericwol-msft @ewertons
Update iothub_client/src/iothubtransport_amqp_twin_messenger.c
d261c00 
Co-authored-by: Ewerton Scaboro da Silva <ewertons@microsoft.com>
@ericwol-msft @ewertons
Update serializer/inc/serializer_devicetwin.h
4efe6d4 
Co-authored-by: Ewerton Scaboro da Silva <ewertons@microsoft.com>
@ericwol-msft ericwol-msft merged commit e2cc0b4 into main Mar 1, 2024
37 checks passed
@ericwol-msft ericwol-msft deleted the ericwol/memcheck branch March 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewertons ewertons ewertons approved these changes

@vaavva vaavva vaavva approved these changes

@RLeclair RLeclair Awaiting requested review from RLeclair RLeclair is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericwol-msft @ewertons @vaavva