Add a client option to specify the sas token ttl and renewal buffer #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
reviewed
Mar 18, 2021
drwill-ms
reviewed
Mar 18, 2021
drwill-ms
reviewed
Mar 18, 2021
drwill-ms
reviewed
Mar 18, 2021
drwill-ms
reviewed
Mar 18, 2021
abhipsaMisra
requested review from
azabbasi,
barustum,
bikamani,
jamdavi,
timtay-microsoft and
vinagesh
as code owners
abhipsaMisra
commented
Mar 19, 2021
abhipsaMisra
force-pushed
the
abmisr/sasTtl
branch
3 times, most recently
from
3b6c836
to
e4c4e9d
Compare
abhipsaMisra
force-pushed
the
abmisr/sasTtl
branch
from
e4c4e9d
to
8df30e0
Compare
abhipsaMisra
commented
Mar 26, 2021
abhipsaMisra
force-pushed
the
abmisr/sasTtl
branch
from
8df30e0
to
2a0f4f9
Compare
abhipsaMisra
force-pushed
the
abmisr/sasTtl
branch
from
259983c
to
0e6ad9d
Compare
abhipsaMisra
commented
Mar 26, 2021
drwill-ms
reviewed
Mar 26, 2021
drwill-ms
reviewed
Mar 26, 2021
drwill-ms
reviewed
Mar 26, 2021
drwill-ms
approved these changes
Mar 26, 2021
drwill-ms
reviewed
Mar 26, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks all for expediting this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the .NET sdk requires you to implement
AuthenticationWithTokenRefreshin order to be able to configure the time to live and renewal buffer value for generated sas tokens. This implementation does require some amount of customer code to be written. It is also currently not supported for edge modules created from environment.This PR introduces an option for users to set a sas token time to live and renewal buffer value into the client options, which would be honored for the
CreateFromConnectionStringandCreateFromEnvironmentflows.Fix for #1818