Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Bump versions for latest release #1842

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

jamdavi
Copy link
Member

@jamdavi jamdavi commented Mar 19, 2021

Microsoft.Azure.Devices.Client 1.36.0

Improvements and Features

Bug Fixes

Microsoft.Azure.Devices 1.31.0

Improvements

  • Update xml comments and backwards compatible changes to the ServiceClient base class that improve the amount of methods to override.

@timtay-microsoft
Copy link
Member

Why is the service client bump a minor version for xml comment changes? Is this to leave room for making the previous version the LTS?

@timtay-microsoft
Copy link
Member

The release notes for the changes I made look good to me, otherwise.

@jamdavi
Copy link
Member Author

jamdavi commented Mar 19, 2021

Why is the service client bump a minor version for xml comment changes? Is this to leave room for making the previous version the LTS?

Good catch. There are changes to ServiceClient abstract class that were rolled into the XML change. Let me edit the release notes to reflect that.

https://github.com/Azure/azure-iot-sdk-csharp/blame/master/iothub/service/src/ServiceClient.cs#L170-L174

https://github.com/Azure/iot-sdks-internals/pull/228/files?diff=split&w=1#diff-b3e67e93c9bae5a283b1d5c913e21f639ff3669d7210faa88b710fccc0d1e35fR618

@vinagesh
Copy link
Member

Looks good other than updating the release notes to reflect why ServiceClient has a minor version bump

@jamdavi
Copy link
Member Author

jamdavi commented Mar 22, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jamdavi jamdavi merged commit 61f682d into master Mar 22, 2021
@jamdavi jamdavi deleted the jamdavi/2021-03-08 branch March 22, 2021 21:06
timstewartm pushed a commit to timstewartm/azure-iot-sdk-csharp that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants