Use await instead of TaskCompletionSource in AsyncExecution #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
8cc0bce
to
86b5ae9
Compare
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
86b5ae9
to
cd84c50
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
3d31d32
to
1e10712
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
1e10712
to
dc70362
Compare
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
dc70362
to
1c6fb72
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
azabbasi,
andyk-ms and
brycewang-microsoft
as code owners
drwill-ms
commented
Mar 19, 2022
drwill-ms
commented
Mar 19, 2022
timtay-microsoft
approved these changes
Mar 21, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azabbasi
approved these changes
Mar 23, 2022
drwill-ms
force-pushed
the
drwill/asyncexecution-rewrite
branch
from
7fe5af1
to
fda3770
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
commented
Mar 23, 2022
azabbasi
approved these changes
Mar 23, 2022
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of existing implementation of AsyncExecution and AsyncExecution. Instead of using TaskCompletionSource and Task.ContinueWith, we just await the task and handle retries in a loop.