Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine getting started folders #2803

Merged
merged 7 commits into from Sep 30, 2022
Merged

combine getting started folders #2803

merged 7 commits into from Sep 30, 2022

Conversation

patilsnr
Copy link
Contributor

No description provided.

@patilsnr patilsnr marked this pull request as ready for review September 30, 2022 22:12
@patilsnr
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@schoims
Copy link
Contributor

schoims commented Sep 30, 2022

Could you update sample links in iothub/device/samples/readme.md accordingly?

brycewang-microsoft
brycewang-microsoft reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@brycewang-microsoft brycewang-microsoft left a comment •
edited by patilsnr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we decide to name the sample sub-folders like "getting started" without capitals?

This is a good question. I noticed in iothub they are lowercase and in provisioning they're uppercase. I think lowercase is better since all our how to and solutions folders are lowercase and I can update these to be consistent.

@patilsnr
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@patilsnr
Copy link
Contributor Author

Did we decide to name the sample sub-folders like "getting started" without capitals?

This is a good question. I noticed in iothub they are lowercase and in provisioning they're uppercase. I think lowercase is better since all our how to and solutions folders are lowercase and I can update these to be consistent.

@patilsnr
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@patilsnr patilsnr enabled auto-merge (squash) September 30, 2022 22:55
@patilsnr
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@patilsnr
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@patilsnr patilsnr merged commit ce53e3d into main Sep 30, 2022
@patilsnr patilsnr deleted the npatilsen/combineGettingStarted branch September 30, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwill-ms drwill-ms drwill-ms approved these changes

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@brycewang-microsoft brycewang-microsoft brycewang-microsoft approved these changes

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

@ngastelum-ms ngastelum-ms Awaiting requested review from ngastelum-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patilsnr @schoims @drwill-ms @abhipsaMisra @timtay-microsoft @brycewang-microsoft