Use the Azure.Core ETag type in the DPS service client #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first class we've added from the Azure.Core package to this library, so we now have a dependency on that package
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
reviewed
Oct 14, 2022
drwill-ms
reviewed
Oct 14, 2022
drwill-ms
reviewed
Oct 14, 2022
| @@ -127,7 +128,12 @@ internal class ContractApiHttp : IContractApiHttp | |||
| msg.Headers.Add(header.Key, header.Value); | |||
| } | |||
| } | |||
| InsertIfMatch(msg, ifMatch); | |||
|
|
|||
| if (!string.IsNullOrWhiteSpace(eTag.ToString())) | |||
There was a problem hiding this comment.
No. It's a struct that may have a null string inside it, though.
drwill-ms
reviewed
Oct 14, 2022
drwill-ms
approved these changes
Oct 14, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first class we've added from the Azure.Core package to this library, so we now have a dependency on that package