Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply JsonSerializerSettings to hub device #3107

Merged
merged 3 commits into from Feb 13, 2023

Conversation

brycewang-microsoft
Copy link
Contributor

Also bring "JsonSerializerSettingsInitializer" from the "shared" folder to both the hub device and service clients separately.

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@drwill-ms drwill-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs comments about the significance of test data and links to the bug we're working around. Also, in the JsonSerializerSettingsInitializer class.

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft brycewang-microsoft merged commit c1d6e97 into main Feb 13, 2023
@brycewang-microsoft brycewang-microsoft deleted the brycewang/main-newtonsoft-fix branch February 13, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants